Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOVCMS-8167] Revert "Prevent output wrapping when running "ahoy drush"" #51

Merged
merged 3 commits into from
Sep 11, 2022

Conversation

Ahmedjabar
Copy link
Contributor

@Ahmedjabar Ahmedjabar commented Sep 3, 2022

This change causes an issue with running drush commands in Gitlab CI because it does not currently support tty (see: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2115).

Copy link
Contributor

@steveworley steveworley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ahmedjabar change looks good to resolve the CI issue - I'm wondering if we can add a default drush-cols or similar to the standard custom.yml file that ships with the scaffolds. Best of both worlds, locally you can use the alternate command if the table output is useful and the CI pipelines don't need to change.

@Ahmedjabar Ahmedjabar force-pushed the revert-45-klonos-do-not-wrap-ahoy-drush-output branch from 3e63893 to a7683b3 Compare September 11, 2022 21:07
@Ahmedjabar
Copy link
Contributor Author

Good point @steveworley - I have added a new option to custom/.ahoy.yml file.

custom/ahoy.yml Outdated Show resolved Hide resolved
@steveworley steveworley merged commit 4fa0f2b into develop Sep 11, 2022
@steveworley steveworley deleted the revert-45-klonos-do-not-wrap-ahoy-drush-output branch September 11, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants